Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the function to list the documents of volumes #50

Merged
merged 3 commits into from
Jun 28, 2018
Merged

Implement the function to list the documents of volumes #50

merged 3 commits into from
Jun 28, 2018
+144 −9

Conversation

hwchiu
Copy link
Contributor

@hwchiu hwchiu commented Jun 27, 2018 •
edited
Loading

  • Also rename the as to sp
  • Add the testing (valid/invalid).

@codecov-io
Copy link

Codecov Report

Merging #50 into develop will increase coverage by 0.38%.
The diff coverage is 87.17%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #50      +/-   ##
===========================================
+ Coverage    78.96%   79.35%   +0.38%     
===========================================
  Files           17       17              
  Lines          466      499      +33     
===========================================
+ Hits           368      396      +28     
- Misses          75       77       +2     
- Partials        23       26       +3
Impacted Files Coverage Δ
src/server/handler_network.go 81% <100%> (ø) ⬆️
src/server/route.go 62.79% <100%> (+0.88%) ⬆️
src/server/handler_volume.go 83.75% <84.37%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4481511...f5e037f. Read the comment docs.

John-Lin
John-Lin suggested changes Jun 28, 2018
View reviewed changes
src/server/handler_volume.go Outdated

count, err := session.Count(entity.VolumeCollectionName, bson.M{})
if err != nil {
logger.Error(err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing return?

@hwchiu hwchiu merged commit a91e4ec into develop Jun 28, 2018
@hwchiu hwchiu deleted the hwchiu/VX-112 branch June 28, 2018 04:06
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #50 from linkernetworks/hwchiu/VX-112
996cdd8 
Implement the function to list the documents of volumes 

Former-commit-id: ddc05b1014cde0d615e65166315f5cf800d4bab7 [formerly a91e4ec]
Former-commit-id: 678bab4ccef92928e4c862674fc66480591d7bc4
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #50 from linkernetworks/hwchiu/VX-112
14ce575 
Implement the function to list the documents of volumes 

Former-commit-id: ddc05b1014cde0d615e65166315f5cf800d4bab7 [formerly ddc05b1014cde0d615e65166315f5cf800d4bab7 [formerly a91e4ec]]
Former-commit-id: 678bab4ccef92928e4c862674fc66480591d7bc4
Former-commit-id: 996cdd8
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #50 from linkernetworks/hwchiu/VX-112
383034e 
Implement the function to list the documents of volumes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@John-Lin John-Lin John-Lin approved these changes

@zyfdegh zyfdegh zyfdegh approved these changes

@sufuf3 sufuf3 sufuf3 approved these changes

@chenyunchen chenyunchen Awaiting requested review from chenyunchen

@WakeupTsai WakeupTsai Awaiting requested review from WakeupTsai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hwchiu @codecov-io @John-Lin @zyfdegh @sufuf3